Fix internal server error display in frontend #7699
Draft
+92
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where internal server error messages were displaying the translation key (e.g., STATUS) instead of the actual translated error message. Changes: 1. Modified ExpandableMessage component to properly handle translation keys in message content 2. Added proper detection of translation keys 3. Hides the expand/collapse arrow when there are no details to show 4. Added test for translation key handling
xingyaoww
force-pushed
the
fix-internal-server-error-display
branch
from
8e0ff07 to
e422a3d
Compare
This commit simplifies the test for translation key handling to avoid issues with mocking the useTranslation hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces.
This PR fixes an issue where internal server error messages were displaying the raw translation key (e.g., STATUS$ERROR_LLM_INTERNAL_SERVER_ERROR) instead of the actual translated error message. Users will now see properly formatted error messages when internal server errors occur.
Give a summary of what the PR does, explaining any non-trivial design decisions.
The PR makes the following changes:
These changes ensure that error messages are properly translated and displayed to users without unnecessary UI elements or showing raw translation keys.
Link of any specific issues this addresses.
N/A
To run this PR locally, use the following command: