Skip to content

Fix mypy errors in storage directory #7692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Apr 3, 2025

This PR fixes mypy errors in the storage directory by:

  • Adding proper return type annotations to functions in conversation_validator.py
  • Removing unnecessary # type: ignore comments in google_cloud.py
  • Removing unnecessary # type: ignore comment in s3.py

All changes are strictly related to fixing type errors and improving type safety. There are no functional changes or unrelated modifications.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:bf14d5e-nikolaik   --name openhands-app-bf14d5e   docker.all-hands.dev/all-hands-ai/openhands:bf14d5e

@neubig neubig enabled auto-merge (squash) April 3, 2025 18:54
@neubig neubig merged commit a899f80 into main Apr 3, 2025
14 checks passed
@neubig neubig deleted the fix/storage-mypy-errors branch April 3, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants