Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of DOCKER_HOST_ADDR #7593

Merged
merged 2 commits into from
Apr 1, 2025
Merged

add support of DOCKER_HOST_ADDR #7593

merged 2 commits into from
Apr 1, 2025

Conversation

yuchenlin
Copy link
Contributor

@yuchenlin yuchenlin commented Mar 31, 2025

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality that this introduces.


Give a summary of what the PR does, explaining any non-trivial design decisions.

This pull request includes changes to the openhands/runtime/impl/docker/docker_runtime.py file to enhance the configuration of the Docker runtime by allowing the use of an environment variable for the Docker host address.

Configuration enhancements:

  • Added import for the os module to handle environment variables.
  • Modified the __init__ method to set the local_runtime_url configuration using the DOCKER_HOST_ADDR environment variable if it is present.

Mainly used for supporting some Docker-in-Docker issue when doing large-scale evaluation. Note that simply using DOCKER_HOST env var cannot enable the routing of runtime correctly.


Link of any specific issues this addresses.
#7568

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@enyst enyst enabled auto-merge (squash) April 1, 2025 14:19
@enyst enyst merged commit 7488d1d into All-Hands-AI:main Apr 1, 2025
13 checks passed
doew pushed a commit to doew/OpenHands that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants