fix(Runtime): Wait for container to start up #7548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tetsu-is
pushed a commit
to Tetsu-is/OpenHands
that referenced
this pull request
Apr 4, 2025
Co-authored-by: openhands <[email protected]> Co-authored-by: tofarr <[email protected]>
Tetsu-is
added a commit
to Tetsu-is/OpenHands
that referenced
this pull request
Apr 4, 2025
…)" This reverts commit 4e69986.
Tetsu-is
pushed a commit
to Tetsu-is/OpenHands
that referenced
this pull request
Apr 4, 2025
Co-authored-by: openhands <[email protected]> Co-authored-by: tofarr <[email protected]>
Tetsu-is
pushed a commit
to Tetsu-is/OpenHands
that referenced
this pull request
Apr 4, 2025
Co-authored-by: openhands <[email protected]> Co-authored-by: tofarr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces.
Fixed a bug where we would not wait for a runtime docker container to be started and instead fail.
Give a summary of what the PR does, explaining any non-trivial design decisions.
While waiting for the container to be ready DockerRuntime._wait_until_alive(), fails because the function self.check_if_alive() itself throws a RetryError which contains a httpx.RemoteProtocolError. Before this retry error stopped the process. Now it continues, until _wait_until_alive has no more retries.
Link of any specific issues this addresses.
#7540