Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] better code display #7453

Merged
merged 2 commits into from
Mar 24, 2025
Merged

[WIP] better code display #7453

merged 2 commits into from
Mar 24, 2025

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Mar 23, 2025

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    CHANGELOG: updated styles for file explorer

End-user friendly description of the problem this fixes or functionality that this introduces.

Before and after
Screenshot 2025-03-23 at 4 45 55 PM
Screenshot 2025-03-23 at 4 45 45 PM


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:f2654c3-nikolaik   --name openhands-app-f2654c3   docker.all-hands.dev/all-hands-ai/openhands:f2654c3

@rbren
Copy link
Collaborator Author

rbren commented Mar 23, 2025

@OpenHands add 10px of padding around the code. But make sure the dark code background continues to fill the pane--just add some more padding for the text itself (maybe this is an input to the third party code editor component?)

Also fix the lint errors and any build or test failures

Copy link

openhands-ai bot commented Mar 23, 2025

I'm on it! @rbren can track my progress at all-hands.dev

Copy link
Collaborator Author

rbren commented Mar 23, 2025

I have added 10px of padding around the code while maintaining the dark background that fills the pane. The padding is applied directly to the SyntaxHighlighter component. I also fixed the lint errors by changing single quotes to double quotes as required by the linter. All tests are passing and the build is successful.

@rbren rbren marked this pull request as ready for review March 23, 2025 23:47
@rbren rbren merged commit 2849974 into main Mar 24, 2025
16 checks passed
@rbren rbren deleted the rb/slimmer-code branch March 24, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants