Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upload functionality and add tooltip for Code not in GitHub link #7431

Merged
merged 13 commits into from
Mar 23, 2025

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Mar 23, 2025

This PR removes the upload functionality from the homepage and adds a tooltip to the "Code not in GitHub?" link with instructions on how to upload files using VS Code.

Upload has been broken for a while, and VS Code is a much better workaround. The tooltip isn't ideal but I think this is an improvement

Screenshot 2025-03-22 at 6 43 17 PM

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:a22d986-nikolaik   --name openhands-app-a22d986   docker.all-hands.dev/all-hands-ai/openhands:a22d986

@rbren rbren marked this pull request as draft March 23, 2025 00:31
@rbren rbren marked this pull request as ready for review March 23, 2025 01:02
@@ -24,12 +24,8 @@ import { useGetTrajectory } from "#/hooks/mutation/use-get-trajectory";
import { downloadTrajectory } from "#/utils/download-trajectory";
import { displayErrorToast } from "#/utils/custom-toast-handlers";

function getEntryPoint(
hasRepository: boolean | null,
hasImportedProjectZip: boolean | null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, FWiW just the other day I tried it, and it did nothing. 🤷

export function CodeNotInGitHubLink() {
return (
<Tooltip
content='To upload files from your computer, start a new project by saying "wait for me to upload files". You can then use the provided VS Code interface to upload any files you want OpenHands to work with. When you&apos;re done, you can also use VS Code to download the changes.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"wait for me to upload files" ?

This doesn't seem ideal. Maybe we could have a way to open the chat interface, instead or from of the home page. It seems strange to have to tell the LLM "hey wait" 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this stinks. Let me think about it for a minute

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK it's a little better now. It still has the "wait for me" prompt but it doesn't make the user type it at least 🙃

We do have plans to support the ability to just jump into the UI without a prompt, but it's not trivial to implement

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I lied it's totally trivial

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Yes, there is no prompt when selecting a repo, so why wouldn't it work. 🤷

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah I tried it and got an error message and gave up. Then I realized it was just the frontend being overzealous 😂

@rbren rbren enabled auto-merge (squash) March 23, 2025 01:43
@rbren rbren merged commit 3061888 into main Mar 23, 2025
17 checks passed
@rbren rbren deleted the remove-upload-add-tooltip branch March 23, 2025 02:03
chuckbutkus pushed a commit that referenced this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants