Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bash SOFT timeout from 30 to 10 seconds #7423

Merged
merged 3 commits into from
Mar 22, 2025
Merged

Conversation

xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Mar 22, 2025

Description

This PR reduces the default timeout for bash commands without any output from 30 seconds to 10 seconds, providing earlier feedback to users when commands stall.

Changes

  • Modified action_execution_server.py to change the default NO_CHANGE_TIMEOUT_SECONDS value from 30 to 10

Testing

  • Existing tests continue to pass

Issue

Fixes #7422

@xingyaoww can click here to continue refining the PR


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:fea55b8-nikolaik   --name openhands-app-fea55b8   docker.all-hands.dev/all-hands-ai/openhands:fea55b8

This change reduces the default timeout for bash commands without any output from 30 seconds to 10 seconds, providing earlier feedback to users when commands stall.
@xingyaoww xingyaoww requested a review from rbren March 22, 2025 22:13
@xingyaoww
Copy link
Collaborator Author

Thinking about it again.. I think it will keep the old timeout (30 sec) for evaluation just to be safe -- but using 10 sec for prod

@xingyaoww xingyaoww enabled auto-merge (squash) March 22, 2025 22:23
@xingyaoww xingyaoww merged commit 01e0e29 into main Mar 22, 2025
13 checks passed
@xingyaoww xingyaoww deleted the reduce-bash-timeout branch March 22, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Drop SOFT bash timeout to 10 seconds
3 participants