-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stream iterator #7384
Fix stream iterator #7384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Co-authored-by: Rohit Malhotra <[email protected]>
It seems like there's similar logic here to fetch first user message: https://github.com/All-Hands-AI/OpenHands/blob/2bd60c87c6b962f9eab97986e67cfff69372c766/openhands/controller/agent_controller.py#L944-#L957 Could possibly de-dup? |
Good point! Lets see |
I moved the dedup here: That PR fixes a bug in the same area. I'll test them both. The reason why that PR is waiting is that I want to make a more complex test with two sessions restored in succession, and for some reason that proved tricky. But I'll finish it asap. |
End-user friendly description of the problem this fixes or functionality that this introduces.
Fix issue that was slowing agent responses as the conversation got longer
Give a summary of what the PR does, explaining any non-trivial design decisions.
Fix iteration - it was going through the whole stream to make a list. 🤦
To run this PR locally, use the following command: