Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Session): add sandbox base, runtime container image to session settings #7329

Merged
merged 4 commits into from
Mar 19, 2025
Merged

feat(Session): add sandbox base, runtime container image to session settings #7329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0eb2ba
add sandbox base, runtime container image to session settings
zaidsheikh Mar 18, 2025
9df2a40
Merge branch 'main' into sandbox-image-session-settings
zaidsheikh Mar 18, 2025
4966517
Do not use default config.runtime_container_image if user specifies s…
zaidsheikh Mar 18, 2025
5e8440e
update config.sandbox.runtime_container_image if user specifies eithe…
zaidsheikh Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions openhands/server/session/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,16 @@ async def initialize_agent(
self.config.security.security_analyzer = (
settings.security_analyzer or self.config.security.security_analyzer
)
self.config.sandbox.base_container_image = (
settings.sandbox_base_container_image
or self.config.sandbox.base_container_image
)
self.config.sandbox.runtime_container_image = (
settings.sandbox_runtime_container_image
if settings.sandbox_base_container_image
or settings.sandbox_runtime_container_image
else self.config.sandbox.runtime_container_image
)
max_iterations = settings.max_iterations or self.config.max_iterations

# This is a shallow copy of the default LLM config, so changes here will
Expand Down
2 changes: 2 additions & 0 deletions openhands/server/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ class Settings(BaseModel):
enable_default_condenser: bool = False
enable_sound_notifications: bool = False
user_consents_to_analytics: bool | None = None
sandbox_base_container_image: str | None = None
sandbox_runtime_container_image: str | None = None

model_config = {
'validate_assignment': True,
Expand Down