-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Rename --repo
argument to --selected-repo
to avoid confusion in the resolver workflow
#7287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename --repo
argument to --selected-repo
to avoid confusion in the resolver workflow
#7287
Conversation
--repo
argument to --owner-repo
to avoid confusion in resolver
--repo
argument to --owner-repo
to avoid confusion in the resolver workflow
--repo
argument to --owner-repo
to avoid confusion in the resolver workflow--repo
argument to --selected-repo
to avoid confusion in the resolver workflow
I kinda wanna add some e2e tests to make sure that the resolver workflow always works in all supported environments (github_token, PAT, gitlab token) but probably not in this PR's scope. |
Looks good to me, thank you! I'd love it if @malhotra5 could take a quick look too. |
This LGTM The workflow file, however, will need to be updated on a future PR The current changes to the resolver won't be available until a release is made (which is when the workflow file should get updated) We should be using release SHA to manage this, but that hasn't been implemented yet |
Just to confirm: |
Yes that would be greatly appreciated! We'll merge this PR right away. The separate PR you create for the workflow diff will get merged right after the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
End-user friendly description of the problem this fixes or functionality that this introduces.
The command-line argument
--repo
was ambiguous, leading to token validation failures when running the resolver. By renaming it to--selected-repo
, the expected format is now more explicit and less prone to errors.Give a summary of what the PR does, explaining any non-trivial design decisions.
Follow up of #7065
In #7065, the bug inside
identify_token
function was resolved by addingrepo
argument and associated validation; however, the main function ofresolve_issue.py
was passing the new argument as a incorrect string format to that function.Within the file
resolve_issue.py
,repo
can mean both{owner}/{repo}
format string and single{repo}
name. To avoid the confusion and to fix the bug properly, this PR tries to rename the argument.Link of any specific issues this addresses.