-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix(frontend): Consistent buttons and their styles throughout the app #6835
Conversation
@amanape I still see a lot of inconsistency in the blue and gray backgrounds |
@amanape let's standardize on the blue, I think it looks better with the yellow |
This PR is actually more buttons-only; bg color consistency is handled in #6833 |
@amanape let's do both in the same PR, otherwise it feels inconsistent |
@rbren I've removed the VSCode logo and the GitHub logo - should I keep both? |
Why not keep them? |
Yeah I think they look better with the logos there |
Consistency reasons - didn't think much of it. Will add them back 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but with three nits to knock out first:
- main bg color I think is the one I suggested--let's revert back to original darker one
- let's make the vscode button a white outline, like the github one
- let's make tab active state by changing the color of the icon to #CEB656 (the logo color), and keeping the text white


…app (All-Hands-AI#6835) Co-authored-by: Robert Brennan <[email protected]>
Brand buttons now support a custom
startContent
that accepts react nodesLink of any specific issues this addresses
To run this PR locally, use the following command: