Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(frontend): Consistent buttons and their styles throughout the app #6835

Merged
merged 11 commits into from
Feb 26, 2025

Conversation

amanape
Copy link
Member

@amanape amanape commented Feb 19, 2025

image

Screenshot 2025-02-20 at 9 17 29 PM
Screenshot 2025-02-20 at 9 17 35 PM

Brand buttons now support a custom startContent that accepts react nodes


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:5faabf8-nikolaik   --name openhands-app-5faabf8   docker.all-hands.dev/all-hands-ai/openhands:5faabf8

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

@amanape I still see a lot of inconsistency in the blue and gray backgrounds

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

I think mainly on the settings page
Screenshot 2025-02-20 at 10 00 07 AM

Screenshot 2025-02-20 at 10 01 04 AM

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

@amanape let's standardize on the blue, I think it looks better with the yellow

@amanape
Copy link
Member Author

amanape commented Feb 20, 2025

This PR is actually more buttons-only; bg color consistency is handled in #6833

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

I think we lost the vscode logo
Uploading Screenshot 2025-02-20 at 10.02.51 AM.png…

@amanape amanape changed the title hotfix(frontend): Consistent buttons and colors throughout the app hotfix(frontend): Consistent buttons and their styles throughout the app Feb 20, 2025
@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

@amanape let's do both in the same PR, otherwise it feels inconsistent

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

VS code logo shot
Screenshot 2025-02-20 at 10 02 51 AM

@amanape
Copy link
Member Author

amanape commented Feb 20, 2025

@rbren I've removed the VSCode logo and the GitHub logo - should I keep both?

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

Why not keep them?

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

Yeah I think they look better with the logos there

@amanape
Copy link
Member Author

amanape commented Feb 20, 2025

Why not keep them?

Consistency reasons - didn't think much of it. Will add them back 👍

@amanape amanape requested a review from rbren February 20, 2025 15:59
Copy link
Collaborator

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but with three nits to knock out first:

  • main bg color I think is the one I suggested--let's revert back to original darker one
  • let's make the vscode button a white outline, like the github one
  • let's make tab active state by changing the color of the icon to #CEB656 (the logo color), and keeping the text white
Screenshot 2025-02-26 at 11 04 14 AM Screenshot 2025-02-26 at 11 01 37 AM

@rbren
Copy link
Collaborator

rbren commented Feb 26, 2025

And lets change modal BG to the secondary color
Screenshot 2025-02-26 at 1 05 44 PM

@amanape amanape enabled auto-merge (squash) February 26, 2025 18:58
@amanape amanape merged commit d5f7dde into main Feb 26, 2025
15 checks passed
@amanape amanape deleted the ALL-1325/button-styles branch February 26, 2025 19:43
adityasoni9998 pushed a commit to adityasoni9998/OpenHands that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants