Skip to content

Only show start project button in conversations #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

mamoodi
Copy link
Collaborator

@mamoodi mamoodi commented Feb 5, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Only show start project button in conversations


Give a summary of what the PR does, explaining any non-trivial design decisions

Tested that the Start new project button only shows when you are in the conversation page.


Link of any specific issues this addresses
#5857


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:fff9cde-nikolaik   --name openhands-app-fff9cde   docker.all-hands.dev/all-hands-ai/openhands:fff9cde

@mamoodi
Copy link
Collaborator Author

mamoodi commented Feb 5, 2025

@amanape thoughts on this solution? It's not that elegant so I'm happy to close if not desirable.
If it's fine, should we wait for Robert to confirm?

@mamoodi mamoodi requested a review from amanape February 5, 2025 22:04
Copy link
Member

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good solution

@mamoodi mamoodi merged commit 669e284 into main Feb 6, 2025
15 checks passed
@mamoodi mamoodi deleted the mh/start-button branch February 6, 2025 14:57
adityasoni9998 pushed a commit to adityasoni9998/OpenHands that referenced this pull request Feb 7, 2025
adityasoni9998 pushed a commit to adityasoni9998/OpenHands that referenced this pull request Feb 7, 2025
chuckbutkus pushed a commit that referenced this pull request Feb 7, 2025
amanape added a commit that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants