Better error logging in posthog #6346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds centralized error logging to PostHog for all errors displayed in the frontend, whether through toasts or in the chat window. Changes include: - New error-handler.ts utility for centralized error handling and logging - Comprehensive test coverage for error logging functionality - Integration with existing error display mechanisms - Consistent metadata handling for better error tracking Resolves #6344
This commit adds centralized error logging to PostHog for all errors displayed in the frontend, whether through toasts or in the chat window. Changes include: - New error-handler.ts utility for centralized error handling and logging - Comprehensive test coverage for error logging functionality - Integration with existing error display mechanisms - Consistent metadata handling for better error tracking Resolves #6344
This was referenced Feb 5, 2025
|
Since I cannot push to this branch, I've PR'd to it in #6641 with some small changes. |
raymyers
reviewed
Feb 6, 2025
frontend/src/utils/error-handler.ts
Outdated
| }: ErrorDetails) { | ||
| logError({ message, source, metadata }); | ||
| toast.custom((t: { id: string }) => | ||
| _jsx(ErrorToast, { id: t.id, error: message }), |
There was a problem hiding this comment.
When I tried this the styling didn't work, so my PR suggestion reverts this to the current behavior, toast.error(...), and we can change the display later.
raymyers
approved these changes
Feb 6, 2025
malhotra5
approved these changes
Feb 6, 2025
adityasoni9998
pushed a commit
to adityasoni9998/OpenHands
that referenced
this pull request
Feb 7, 2025
Co-authored-by: openhands <[email protected]> Co-authored-by: Ray Myers <[email protected]>
adityasoni9998
pushed a commit
to adityasoni9998/OpenHands
that referenced
this pull request
Feb 7, 2025
Co-authored-by: openhands <[email protected]> Co-authored-by: Ray Myers <[email protected]>
chuckbutkus
pushed a commit
that referenced
this pull request
Feb 7, 2025
Co-authored-by: openhands <[email protected]> Co-authored-by: Ray Myers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Add comprehensive error logging to PostHog
Give a summary of what the PR does, explaining any non-trivial design decisions
This commit adds centralized error logging to PostHog for all errors displayed in the frontend, whether through toasts or in the chat window. Changes include:
Link of any specific issues this addresses
Resolves #6344
To run this PR locally, use the following command: