Skip to content

Clean up unused workflows #5235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Clean up unused workflows #5235

merged 1 commit into from
Nov 24, 2024

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented Nov 24, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR proposes to:

  • disable the nightly schedule on the eval-this workflow. It isn't working, but it does try to run 20k lines of log worth of attempts, using the remote runtime - example
  • remove the old PR review workflow.

I'm not sure about the removal of the PR review workflow... I think that since it isn't working right now, it needs a bit of looking into, but it seems like it would be better to fix it based on the resolver rather than a custom main.py run, as it used to be implemented. That probably means this won't be reused and we can look at building it on the resolver. If you feel like it's still useful, let's keep it for now though...


Link of any specific issues this addresses
Related to #5106


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:d7ee8d3-nikolaik   --name openhands-app-d7ee8d3   docker.all-hands.dev/all-hands-ai/openhands:d7ee8d3

@enyst enyst requested a review from neubig November 24, 2024 12:55
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@neubig neubig merged commit da7963e into main Nov 24, 2024
13 checks passed
@neubig neubig deleted the enyst/disable-unused-workflows branch November 24, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants