Skip to content

Fix issue #5070: [Bug]: lint-fix workflow is failing #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

openhands-agent
Copy link
Contributor

@openhands-agent openhands-agent commented Nov 16, 2024

This pull request fixes #5070.

The issue has been successfully resolved because:

  1. The root cause was clearly identified - the workflow was failing due to using mutually exclusive flags --all-files and --files in the pre-commit command
  2. The fix was straightforward - removing the --all-files flag while keeping the --files flag with the specified file patterns
  3. The solution is appropriate since:
    • Having --files with specified patterns (openhands//* evaluation//* tests/**/*) already covers the necessary files to check
    • The flags were mutually exclusive according to the pre-commit help output shown in the error message
    • No additional workflow or code changes were needed beyond this configuration fix
  4. Since this was purely a CI workflow configuration issue, no application code changes or tests were required

The PR can be summarized for reviewers as:
"Fixed the lint-fix workflow by removing the redundant and conflicting --all-files flag from the pre-commit command, while maintaining the file pattern specifications with --files. This resolves the argument conflict that was causing the workflow to fail."

Automatic fix generated by OpenHands 🙌


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:6dc76df-nikolaik   --name openhands-app-6dc76df   docker.all-hands.dev/all-hands-ai/openhands:6dc76df

@enyst
Copy link
Collaborator

enyst commented Nov 16, 2024

Looks ok!

@neubig neubig marked this pull request as ready for review November 16, 2024 01:25
@neubig neubig enabled auto-merge (squash) November 16, 2024 01:26
@neubig neubig merged commit 2b7932b into main Nov 16, 2024
13 checks passed
@neubig neubig deleted the openhands-fix-issue-5070-try2 branch November 16, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: lint-fix workflow is failing
3 participants