test: Fix test_config.py fails when variables are set externally in the environment #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neubig Can you please review this and merge? |
|
@neubig Can we merge this ?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the problem this fixes or functionality that this introduces. This may be used for the CHANGELOG
Fixes: #3572
Mocked env variables to fix the failing tests.
Give a summary of what the PR does, explaining any non-trivial design decisions
We were expecting the value of LLM_MODEL to be None, so I just deleted that env if it is set externally using monkey patch. This will fix the issue of this variable getting set externally and failing the tests.
Link of any specific issues this addresses
#3572