Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) runtime: in _wait_until_alive upon start wait for client to have initialized too #3612

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

tobitege
Copy link
Collaborator

@tobitege tobitege commented Aug 27, 2024

Short description of the problem this fixes or functionality that this introduces. This may be used for the CHANGELOG

EventStreamRuntime will wait for runtime client to be initialized once, for up to 10s.


Give a summary of what the PR does, explaining any non-trivial design decisions

The runtime starts the client and should wait for its full initialization before resuming normal processing.
This will only be done once and only for up to 10 seconds so to not get stuck.

@xingyaoww Let me know what you think about this approach.

@tobitege tobitege added enhancement New feature or request backend Related to backend labels Aug 27, 2024
@tobitege tobitege requested a review from xingyaoww August 27, 2024 12:42
Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

"/alive" return success basically means runtime client is also initialized -- Based on my understanding, this PR should help with the logging before the runtime client is alive, right? (e.g., we get more info about the initialization process)

@tobitege
Copy link
Collaborator Author

LGTM!

"/alive" return success basically means runtime client is also initialized -- Based on my understanding, this PR should help with the logging before the runtime client is alive, right? (e.g., we get more info about the initialization process)

The container already gives you the alive signal before the client is initialized, that's why I thought this PR makes sense to avoid delayed "clashes" if the runtime would start with sending commands and the client still starting.

@tobitege tobitege merged commit 1fddc77 into main Aug 27, 2024
@tobitege tobitege deleted the wait-for-client-init branch August 27, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants