Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now checking for the meta (Command) key as well as the ctrl key #3484

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Aug 19, 2024

This is designed to address #3483

There was code here checking for users pressing Ctrl+C / Ctrl+V but not Cmd+C / Cmd+V (As on a mac keyboard). After this PR, we check for this too:

Copy from external source

image

Paste using Cmd+V:

image

@enyst
Copy link
Collaborator

enyst commented Aug 19, 2024

Good catch!

@amanape
Copy link
Member

amanape commented Aug 20, 2024

Woops, didn't realize this was still a draft! I will verify it once its opened

@tofarr tofarr marked this pull request as ready for review August 20, 2024 10:52
@tofarr tofarr merged commit 5e1d55f into main Aug 20, 2024
@tofarr tofarr deleted the fix-copy-paste-terminal-for-mac branch August 20, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants