Remove concurrency options from ghcr.yml #3457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iFurySt
previously approved these changes
Aug 19, 2024
mamoodi
reviewed
Aug 19, 2024
| @@ -149,7 +216,7 @@ jobs: | |||
| test_runtime: | |||
There was a problem hiding this comment.
When you say you are getting it unstuck, do you mean the job never runs sometimes? Or the job itself gets stuck?
There was a problem hiding this comment.
It just doesn't start, ever. Across multiple PR's.
There was a problem hiding this comment.
Ah interesting. It may be just because of the concurrency. Did you try just removing that at first?
In the builds that it never starts, do you see the ghcr_build_runtime job pass successfully?
mamoodi
reviewed
Aug 19, 2024
|
This was good for testing, but closing as there'll be other PR's for it. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
concurrencyoption fromghcr.ymlto avoid skipping of crucial workflows.Attempting to get the
Test Runtime (eventstream)get unstuck, for testing :ghcr_build_runtimeinto 2 separate platform jobs foramd64andarm64needsforTest Runtime (eventstream)to just the amd64 job