Skip to content

fix: copy over pyproject and poetry lock for App docker #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

xingyaoww
Copy link
Collaborator

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?

Fix #3283.


Give a summary of what the PR does, explaining any non-trivial design decisions

  • Include pyproject.toml and poetry.lock inside app container, since it is required for EventStreamRuntime builder to create source code distribution

Other references

Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other files that we need to change the permissions on?

@xingyaoww
Copy link
Collaborator Author

@tofarr I think pyproject.toml and poetry.lock should be sufficient :D Let's test the built container in this PR to see if it fixes the issue before merge

@xingyaoww
Copy link
Collaborator Author

Ok seems i missed the README.md... Locally build and tested it, now it is able to launch

@xingyaoww xingyaoww enabled auto-merge (squash) August 8, 2024 18:52
@xingyaoww xingyaoww merged commit 4915168 into main Aug 8, 2024
@xingyaoww xingyaoww deleted the xw/fix-main-docker branch August 8, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 'ServerRuntime' object has no attribute 'file_store'
2 participants