Skip to content

(fix) tests: temp_dir fixture fix in 4 tests #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

tobitege
Copy link
Collaborator

@tobitege tobitege commented Jul 29, 2024

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?

  • several tests had a missing temp_dir parameter in the fixture

Other references

#3128

@tobitege tobitege requested a review from xingyaoww July 29, 2024 08:26
@tobitege tobitege added enhancement New feature or request test labels Jul 29, 2024
Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

@tobitege
Copy link
Collaborator Author

@xingyaoww how about I revert the bash parsing method again, so that we can get the temp file fixture fixed asap instead?

@xingyaoww
Copy link
Collaborator

@tobitege sounds good to me!

@xingyaoww xingyaoww enabled auto-merge (squash) July 29, 2024 16:32
@tobitege tobitege changed the title (fix) split_bash_commands replaced; temp_dir fixture fix in some tests (fix) tests: temp_dir fixture fix in 4 tests Jul 29, 2024
@xingyaoww xingyaoww merged commit 2533efa into All-Hands-AI:main Jul 29, 2024
@tobitege tobitege deleted the tests-and-bash branch July 29, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants