-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(test,CI): runtime build tests #3126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it :)
Hey @xingyaoww , did you confirm that the tests in |
Yeah... I think after moving the |
Actually You can run them locally by doing
|
@neubig We have dedicated workflow |
Ohh, I see! My bad. |
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
@tobitege find that
test_runtime_build.py
failed to run, yet all those CI passed.Give a summary of what the PR does, explaining any non-trivial design decisions
test_runtime_build.py
so it matches the current implementation.run-unit-tests.yml
sotest_runtime_build.py
is included in the testing.Other references