Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(test,CI): runtime build tests #3126

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Conversation

xingyaoww
Copy link
Collaborator

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?

@tobitege find that test_runtime_build.py failed to run, yet all those CI passed.


Give a summary of what the PR does, explaining any non-trivial design decisions

  • Fix test_runtime_build.py so it matches the current implementation.
  • Update run-unit-tests.yml so test_runtime_build.py is included in the testing.

Other references

@xingyaoww xingyaoww added the test label Jul 26, 2024
@xingyaoww xingyaoww requested a review from tobitege July 26, 2024 13:35
Copy link
Collaborator

@tobitege tobitege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it :)

@xingyaoww xingyaoww merged commit 1f6e86c into main Jul 26, 2024
2 checks passed
@xingyaoww xingyaoww deleted the xw/fix-runtime-build-tests branch July 26, 2024 14:53
@neubig
Copy link
Contributor

neubig commented Jul 26, 2024

Hey @xingyaoww , did you confirm that the tests in test_sandbox.py and test_runtime.py run? I fixed some bugs in the jupyter test, but they don't seem to be fixe din this PR...

@xingyaoww
Copy link
Collaborator Author

Yeah... I think after moving the sandbox-related test to test_sanbdox, these tests passed the CI?
https://github.com/OpenDevin/OpenDevin/actions/runs/10112691054/job/27968196884

@neubig
Copy link
Contributor

neubig commented Jul 26, 2024

Actually test_sandbox is not tested by CI:
https://github.com/OpenDevin/OpenDevin/blob/1f6e86c932e16914b94a673f22fc791cd8d4d58c/.github/workflows/run-unit-tests.yml#L128

You can run them locally by doing

poetry run pytest ./tests/unit/test_sandbox.py
poetry run pytest ./tests/unit/test_runtime.py

@xingyaoww
Copy link
Collaborator Author

xingyaoww commented Jul 26, 2024

@neubig
Copy link
Contributor

neubig commented Jul 26, 2024

Ohh, I see! My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants