Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: evaluation leaks api_key in metadata; fix llm_config argument in run infer #2998

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

xingyaoww
Copy link
Collaborator

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?

  • after the global config refactor Remove global args #2760, llm_config inside EvalMetadata no longer hides sensitive info when dumped into JSON.
  • the LLM's input keyword argument change from llm_config to config

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Hide sensitive info when try to dump EvalMetadata into a JSON via model_dump_json
  • Fix all occurrence of llm_config= to config= in all run_infer.py

Other references

@xingyaoww xingyaoww requested a review from neubig July 18, 2024 14:50
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@neubig neubig enabled auto-merge (squash) July 18, 2024 14:57
@neubig neubig merged commit cf910df into main Jul 18, 2024
2 checks passed
@neubig neubig deleted the xw/fix-eval-info-leak branch July 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants