[Arch] EventStreamRuntime supports browser
#2899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
12 tasks
yufansong
approved these changes
Jul 11, 2024
Comment on lines
+216
to
220
| # An eventstream runtime image is already built for the base image (with poetry and dev dependencies) | ||
| # but it might not contain the latest version of the source code and dependencies. | ||
| # So we need to build a new (dev) image with the latest source code and dependencies. | ||
| # FIXME: In production, we should just build once (since the source code will not change) | ||
| base_image = new_image_name |
There was a problem hiding this comment.
I think for dev, we can just mount the project into the sandbox and manually launch it. Build a image maybe too heavy just for development.
There was a problem hiding this comment.
Good point! But beyond the codebase, we might still need to update the dependency - mounting & poetry install at the launch time might make the code a little bit complex, but can help reduce unnecessary re-build of docker images. And how to effectively switch between dev and prod (via config?) is also a question..
I'll give it more thoughts!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
This is part of #2404.
Right now, the
RuntimeClientrunning inside the sandbox supports running Browser actions.Give a brief summary of what the PR does, explaining any non-trivial design decisions
RuntimeClientto be executed inside sandbox.Command to test
python3 opendevin/runtime/client/runtime.pyExample output:
Other references