Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Update regenerate.sh #2832

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

SmartManoj
Copy link
Contributor

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
#2824 (comment) Removing the current directory in WSL makes the OS unstable.

Give a brief summary of what the PR does, explaining any non-trivial design decisions
Just removing the directory's content only.

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read #2824 (comment) but I don't understand why this change would result in any useful change in behavior and fix the problem. Could you please provide more evidence or justification for this change?

@tobitege
Copy link
Collaborator

tobitege commented Jul 7, 2024

I read #2824 (comment) but I don't understand why this change would result in any useful change in behavior and fix the problem. Could you please provide more evidence or justification for this change?

The detail is around here:
#2824 (comment)

The regenerate whilst running removes the carpet below the script's feet and then a "getcwd()" call causes an exception and shows up as EFileNotFoundError. It's an annoying circumstance. One has to actually change the folder and get back to re-start the script without error, it's weird.

This should go in, imo.

Copy link
Collaborator

@tobitege tobitege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that's fine with me then.

@tobitege tobitege merged commit c6aa507 into All-Hands-AI:main Jul 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants