Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back jupyter PWD env var for agentskills #2327

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Conversation

xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Jun 8, 2024

We introduce JUPYTER_PWD in https://github.com/OpenDevin/OpenDevin/pull/2105/files#diff-fbc8351b325a35a525f30e58eae651dbd50b3692963c81b989bee4dac617511c, so that every create_file, open_file command from agentskills is aware of the (bash's) current working directory.

It got accidentally removed in this commit: 78e003c

Adding it back now.

Example, when cd into a folder aaa, the new create_file command should create file inside aaa, instead of `/workspace':
image

@xingyaoww
Copy link
Collaborator Author

xingyaoww commented Jun 8, 2024

pls Hold-off the merging for a bit - I'm trying to add a unit test to catch this

EDIT: ready now! waiting for workflow to finish.

@xingyaoww xingyaoww enabled auto-merge (squash) June 8, 2024 08:48
@xingyaoww xingyaoww merged commit 903381f into main Jun 8, 2024
2 checks passed
@xingyaoww xingyaoww deleted the xw/fix-jupyter-cwd branch June 8, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants