Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #2267

Merged
merged 26 commits into from
Jun 5, 2024
Merged

fix typos #2267

merged 26 commits into from
Jun 5, 2024

Conversation

RainRat
Copy link
Contributor

@RainRat RainRat commented Jun 5, 2024

No description provided.

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tobitege
Copy link
Collaborator

tobitege commented Jun 5, 2024

"shoud" needs to be fixed also in the *.log files below or the integration tests fail:
grafik

However, this should only be merged when the maintainers are done with evaluations.

Copy link
Collaborator

@iFurySt iFurySt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration tests failed.

@tobitege
Copy link
Collaborator

tobitege commented Jun 5, 2024

The integration tests failed.

I know, it's a devil's circle now lol Can't fix 'cause errors. Some maintainer needs to force a commit.

@iFurySt
Copy link
Collaborator

iFurySt commented Jun 5, 2024

the integration tests failed. we can wait for the @li-boxuan to be free to have a look, but we are currently foucused on the NeurIPS D&B DDL :)

implement the solution. If the codebase is empty, you shoud call the `finish` action.
implement the solution. If the codebase is empty, you should call the `finish` action.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change cause the integration failed. You should also change the corressponding prompt files.

tests/integration/test_agent.py Mismatched Prompt File path /home/runner/work/OpenDevin/OpenDevin/tests/integration/mock/DelegatorAgent/test_edits/prompt_001.log
------------------------------
Diff:
--- /home/runner/work/OpenDevin/OpenDevin/tests/integration/mock/DelegatorAgent/test_edits/prompt_001.log	2024-06-05 09:09:05.233456930 +0000
+++ /tmp/tmp9e27b5bc	2024-06-05 09:11:22.008845[67](https://github.com/OpenDevin/OpenDevin/actions/runs/9381353499/job/25830424513?pr=2267#step:7:68)4 +0000
@@ -34,7 +34,7 @@
 codebase are relevant to the project, including particular files, functions, and classes.
 When you're done, put your summary in `outputs.summary` in the `finish` action.
 Remember, your task is to explore and study the current repository, not actually
-implement the solution. If the codebase is empty, you shoud call the `finish` action.
+implement the solution. If the codebase is empty, you should call the `finish` action.
 
 ## History
 Here is a recent history of actions you've taken in service of this plan,
@@ -83,4 +83,4 @@
   }
 }
 
---- END OF EXAMPLE ---
+--- END OF EXAMPLE ---
\ No newline at end of file

@yufansong
Copy link
Collaborator

Integrate test passed, good to merge now. @iFurySt pls AP it.

@iFurySt iFurySt merged commit 3b0e136 into All-Hands-AI:main Jun 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants