Revamp AgentRejectAction and allow ManagerAgent to handle rejection #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
=======================================
Coverage ? 58.47%
=======================================
Files ? 99
Lines ? 4058
Branches ? 0
=======================================
Hits ? 2373
Misses ? 1685
Partials ? 0 ☔ View full report in Codecov by Sentry. |
yufansong
previously approved these changes
May 12, 2024
li-boxuan
changed the title
|
Blocked by #1897 |
6 tasks
li-boxuan
added a commit
that referenced
this pull request
May 29, 2024
This PR fixes #1897. In addition, this PR fixes and tweaks a few micro-agents. For the first time, I am able to use ManagerAgent to complete test_write_simple_script and test_edits tasks in integration tests, so this PR also adds ManagerAgent as part of integration tests. test_write_simple_script involves delegation to CoderAgent while test_edits involves delegation to TypoFixerAgent. Also for the first time, I am able to use DelegateAgent to complete test_write_simple_script and test_edits tasks in integration tests, so this PR also adds DelegateAgent as part of integration tests. It involves delegation to StudyRepoForTaskAgent, CoderAgent and VerifierAgent. This PR is a blocker for #1735 and likely #1945.
|
Hi @li-boxuan , I'm just going through the backlog, you're still working on and interested in this right? It seems that #1910 was a step in the right direction. |
|
@neubig Yep I am working on it. Was busy with some benchmark work earlier but I am back on track with this now. |
|
Have to put this on hold again. Need to focus on wrapping up evaluations and paper. |
neubig
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
This looks good, thanks @li-boxuan ! I think it can be merged after conflicts are resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1615 introduced a new action type called
AgentRejectAction, but was accidentally removed in #1626, likely due to merge conflict resolution. This PR adds reject action handling back.This PR also: