Add permanent storage option for EventStream #1697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assertion
reviewed
May 11, 2024
| AWS_S3_ENDPOINT = 's3.amazonaws.com' | ||
|
|
||
|
|
||
| class S3FileStore(FileStore): |
There was a problem hiding this comment.
I think maybe put s3.py into a directory of cloud provider will be better, so we can add some other cloud file storage like azure bolb, Google Cloud Storage.
There was a problem hiding this comment.
agree we'll probably add these in the future! Let's create a subdirectory then if we decide we need it
|
good catch @assertion! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
Coverage ? 61.37%
=======================================
Files ? 108
Lines ? 4241
Branches ? 0
=======================================
Hits ? 2603
Misses ? 1638
Partials ? 0 ☔ View full report in Codecov by Sentry. |
enyst
reviewed
May 14, 2024
enyst
approved these changes
May 14, 2024
|
I haven't got to test it, otherwise LGTM! |
rbren
commented
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows EventStream to persist to a local or remote filesystem, instead of keeping all state in-memory.
This is helpful for a high-availability situation. For example, currently, if you rolled out a new deployment, any websockets would be disconnected, existing user sessions would be cancelled, and all the session data would be lost.
With this change, the client could reconnect to a new instance of the application, and the EventStore could rehydrate from persistent storage.
This change also factors action/observation/event serialization and deserialization into its own spot, to avoid circular imports