Skip to content

test(frontend): update unit tests #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024
Merged

test(frontend): update unit tests #1598

merged 1 commit into from
May 6, 2024

Conversation

amanape
Copy link
Member

@amanape amanape commented May 5, 2024

Summary

Updates the tests according to changes made in #1538.

Fixes

The test it("should render the new message the user has typed") no longer fails due to the Redux store not updating. The dispatch was called outside the component with the store object directly. We end up have more than one store in the app, which is not advised.

Improvements

  • Removed the need for preloaded task state (removal of initialized from taskSlice)

@amanape amanape requested a review from rbren May 5, 2024 20:59
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@f7e0c6c). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1598   +/-   ##
=======================================
  Coverage        ?   62.43%           
=======================================
  Files           ?       91           
  Lines           ?     3711           
  Branches        ?        0           
=======================================
  Hits            ?     2317           
  Misses          ?     1394           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbren
Copy link
Collaborator

rbren commented May 6, 2024

Thanks for cleaning up my mess 😄

@rbren rbren merged commit 35b248f into All-Hands-AI:main May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants