Skip to content

DDR3 Requires Instantiation to use parameters #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ajstros opened this issue Jun 28, 2022 · 0 comments
Open

DDR3 Requires Instantiation to use parameters #6

Ajstros opened this issue Jun 28, 2022 · 0 comments
Assignees

Comments

@Ajstros
Copy link
Owner

Ajstros commented Jun 28, 2022

Some values in the DDR3 parameters attribute are useful outside of the DDR3, such as "update_period" and "sample_size". These are currently assigned only when the DDR3 is instantiated. Additionally, the DDR3 instantiation requires an FPGA instance, and that instance must have run FPGA.init_device already to get the xem attribute. I believe that is from line 80:

self.clear_adc_debug()

The biggest concern is having to run FPGA.init_device since we don't always have an FPGA connected when we need "parameters" values. (e.g. setting up data for DDR and needing "update_period" and "sample_size" to do so).

I think this can be solved by making parameters a class attribute instead of an instance attribute. While this change is being made, it also makes sense to take the values out of parameters, making them separate attributes of the class. This will allow autocomplete and better syntax highlighting in editors.

@Ajstros Ajstros self-assigned this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant