Resolve: #296 Hide url box when going fullscreen #297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #296
On current-window.js added to the array EVENTS: “enter-full-screen”, “leave-full-screen”.
On script.js added the events that detect entering and leaving the full screen and toggle the nav class ‘hidden’. Also it resizes the view.
currentWindow.on('enter-full-screen', () => {
if (!rawFrame) nav.classList.toggle('hidden', true)
webview.emitResize()
})
currentWindow.on('leave-full-screen', () => {
if (!rawFrame) nav.classList.toggle('hidden', false)
webview.emitResize()
})
On windows.js added the listeners for the events:
this.window.on('enter-full-screen', () => {
this.send('enter-full-screen')
})
this.window.on('leave-full-screen', () => {
this.send('leave-full-screen')
})