Skip to content

Resolve: #296 Hide url box when going fullscreen #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

OmarBustamante
Copy link
Contributor

@OmarBustamante OmarBustamante commented Jun 23, 2025

Resolve: #296
On current-window.js added to the array EVENTS: “enter-full-screen”, “leave-full-screen”.

On script.js added the events that detect entering and leaving the full screen and toggle the nav class ‘hidden’. Also it resizes the view.
currentWindow.on('enter-full-screen', () => {
if (!rawFrame) nav.classList.toggle('hidden', true)
webview.emitResize()
})
currentWindow.on('leave-full-screen', () => {
if (!rawFrame) nav.classList.toggle('hidden', false)
webview.emitResize()
})

On windows.js added the listeners for the events:
this.window.on('enter-full-screen', () => {
this.send('enter-full-screen')
})
this.window.on('leave-full-screen', () => {
this.send('leave-full-screen')
})

@OmarBustamante OmarBustamante changed the title Issue #296 Hide url box when going fullscreen resolve #296 Hide url box when going fullscreen Jun 24, 2025
@OmarBustamante OmarBustamante changed the title resolve #296 Hide url box when going fullscreen resolve: #296 Hide url box when going fullscreen Jun 24, 2025
@OmarBustamante OmarBustamante changed the title resolve: #296 Hide url box when going fullscreen Resolve: #296 Hide url box when going fullscreen Jun 24, 2025
Copy link
Member

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect, thank you! I'll include it in the next release.

Glad this also fixes the resizing issue when exiting fullscreen for youtube and the such.

@RangerMauve RangerMauve merged commit bfcf2ec into AgregoreWeb:master Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide url box when going fullscreen
2 participants