Skip to content

adopt workspace: protocol #11397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025
Merged

adopt workspace: protocol #11397

merged 3 commits into from
May 28, 2025

Conversation

turadg
Copy link
Member

@turadg turadg commented May 21, 2025

refs: #451

Description

Now that we're past Yarn 1, we can use more modern package management features like workspace: protocol.

It's also supported by NPM v7+, but for some reason xsnap install balks at it so b4d4f51 reverts it for that one package. cc @kriskowal for ideas to solve that

Security Considerations

Marginal benefit to prevent NPM fetch if a dep mismatches local version.

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

Here's how I made the change:
find: "@agoric/(.+)": "^."
replace: "@agoric/$1": "workspace:
"

Upgrade Considerations

n/a

Copy link

cloudflare-workers-and-pages bot commented May 21, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 57e542d
Status: ✅  Deploy successful!
Preview URL: https://81a59cf1.agoric-sdk.pages.dev
Branch Preview URL: https://ta-adopt-protocol.agoric-sdk.pages.dev

View logs

@turadg turadg added the force:integration Force integration tests to run on PR label May 21, 2025
@turadg turadg changed the title adopt Yarn workspace protocol adopt workspace: protocol May 21, 2025
@turadg turadg force-pushed the ta/adopt-protocol branch from 2c8a715 to ac318a8 Compare May 22, 2025 22:59
@turadg turadg requested review from kriskowal and samsiegart May 22, 2025 23:03
Copy link
Contributor

@samsiegart samsiegart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool TIL, will look into this for ui-kit. Deferring approval to @kriskowal

@turadg turadg marked this pull request as ready for review May 23, 2025 18:28
@turadg turadg requested a review from a team as a code owner May 23, 2025 18:28
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label May 24, 2025
Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find time to investigate why this does not work for xsnap. Please feel free to assign that investigation to me.

turadg added 3 commits May 28, 2025 00:25
find: "@agoric/(.+)": "\^.*"
replace: "@agoric/$1": "workspace:*"
npm error code EUNSUPPORTEDPROTOCOL␊
npm error Unsupported URL Type "workspace:": workspace:*␊
@mergify mergify bot force-pushed the ta/adopt-protocol branch from ac318a8 to 57e542d Compare May 28, 2025 00:25
@mergify mergify bot merged commit 1d681c8 into master May 28, 2025
86 of 89 checks passed
@mergify mergify bot deleted the ta/adopt-protocol branch May 28, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants