Skip to content

fix: use Atom instead of Primitive for passables #11348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erights
Copy link
Member

@erights erights commented May 2, 2025

#endo-branch: master

Assumes current endo

closes: #XXXX
refs: endojs/endo#2791

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

@erights erights self-assigned this May 2, 2025
Copy link

cloudflare-workers-and-pages bot commented May 2, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 04c38c8
Status:🚫  Build failed.

View logs

Co-authored-by: Richard Gibson <[email protected]>
@kriskowal
Copy link
Member

@erights Since renaming this type creates churn in Agoric SDK, let’s consider creating an alias. I think the alignment in names with OCapN is going to be less important than keeping Agoric SDK development stable.

@erights
Copy link
Member Author

erights commented May 8, 2025

I thought I already did: https://github.com/endojs/endo/blob/14ddadb5ffec4ee7d3bf5ccdd9008ac368d8f4aa/packages/pass-style/src/types.d.ts#L28C1-L40C1

/**
 * @deprecated Use `Atom` instead, which is also the ocapn name. Now that
 * ByteArray has been added, this category no longer corresponds to
 * JS primitives, We also expect to move  to a passable-symbol representation
 * as a JS object, not a JS primitive
 */
export type Primitive = Atom;

/**
 * @deprecated Use `AtomStyle` instead. See `Atom` vs `Primitive`.
 */
export type PrimitiveStyle = AtomStyle;

I did this so agoric-sdk could work across this endo change without needing adjustment. This agoric-sdk PR can be indefinitely postponed.

Does this preservation of the previous type name exports work for current agoric-sdk? If not, we should definitely fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants