docs: orchestration contract package skeleton #11323
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o orchestration contract
- fix liquid staking / forwarding logic - StrideAccount is not ICA - make a stride account for strideAddr - punt resolve; it's just promise resolution
dckc
requested review from
turadg,
dtribble,
LuqiPan,
samsiegart,
0xpatrickdev and
amessbee
turadg
reviewed
Apr 23, 2025
I'll give it a quick try... |
dckc
commented
Apr 23, 2025
| "@agoric/fast-usdc": "^0.1.0", | ||
| "@agoric/internal": "^0.3.2", | ||
| "@agoric/swingset-liveslots": "^0.10.2", | ||
| "@agoric/vow": "^0.1.0", |
There was a problem hiding this comment.
@turadg when I use a new repository, I get a bunch of...
? Please choose a version of "@agoric/vow" from this list: 0.2.0-upgrade-20-dev-ef71
cfd.0
I guess I could use dev packages. But then it's another independent set of dependencies to track. hm.
dckc
commented
Apr 23, 2025
| "test:c8": "c8 --all $C8_OPTIONS ava", | ||
| "test:xs": "exit 0", | ||
| "lint-fix": "yarn lint:eslint --fix", | ||
| "lint": "run-s --continue-on-error lint:*", |
There was a problem hiding this comment.
in a new repo, yarn lint says /bin/sh: 1: run-s: not found
dckc
commented
Apr 23, 2025
| ], | ||
| "scripts": { | ||
| "build": "exit 0", | ||
| "test": "ava", |
There was a problem hiding this comment.
in a new repo, yarn test says:
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/connolly/projects/orch-skel/node_modules/@agoric/orchestration/test/network-fakes.ts' imported from /home/connolly/projects/orch-skel/test/supports.ts
|
@dtribble suggested merging the current work on the swap component into this branch. |
Deploying agoric-sdk with
|
| Latest commit: |
674bbf0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://025f308d.agoric-sdk.pages.dev |
| Branch Preview URL: | https://dc-orch-template.agoric-sdk.pages.dev |
|
@dtribble also asked whether the skeleton here is transactional or portfolio; implicitly that suggests adding a portfolio example. Meanwhile, we do have other portfolio example materials:
|
dckc
force-pushed
the
dc-orch-template
branch
2 times, most recently
from
ffa30d9 to
674bbf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Intended for use as the basis of SPIKE projects. Do not merge.
To develop an orchestration contract:
test/my-orch-sequence.mmd@agoric/orchestrationobjects and messagestest/my-orch-seq-sim.test.tssrc/my.contract.ts) with flows (my.flows.ts) and make a test for it (test/my-orch-contract.test.ts)Template orchestration contract package, extracted from
fast-usdc-contractand some earlier teaching materials. Written in typescript.Further refinements should add a
orch-skel-deploypackage and perhaps separate anorch-skel-contractpackage from theorch-skelAPI package.Security / Scaling / Upgrade Considerations
N/A
Testing Considerations
Includes a couple very basic tests.