Upgrade vat-bank #11269
Upgrade vat-bank #11269
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
e27076d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2223be3b.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mhofman-upgrade-bank.agoric-sdk.pages.dev |
| export const bankSend = (addr, wanted, from = VALIDATORADDR) => { | ||
| return agd.tx(['bank', 'send', from, addr, wanted], { |
There was a problem hiding this comment.
The call to makeAgd is just right, except that it's at module scope.
So the exported bankSend closes over execFileSync.
I'd really rather we stuck to OCap Discipline house style rather than digging deeper...
There was a problem hiding this comment.
This is just restoring the relevant a3p tests as they existed in u19, and slightly modifies them as some tests depended on each other. I am not willing to rewrite / refactor them
mergify
bot
force-pushed
the
mhofman/upgrade-bank
branch
from
2139a9f to
d8ecc56
Compare
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You may have to fix your CI before adding the pull request to the queue again. |
mhofman
force-pushed
the
mhofman/upgrade-bank
branch
from
d8ecc56 to
e27076d
Compare
refs: #11118
Description
vat-bank is leaking. We suspect this is due to the liveslots resolved promise leak. Upgrade vat-bank to pick up the liveslots fix
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
There doesn't seem to be an upgrade test specific to vat-bank, but apparently the provision pool test relies on vat-bank functioning, so restore that test from upgrade-19
Upgrade Considerations
Upgrade a vat as part of the next chain software upgrade.