Skip to content

docs(README): Better explain Docker image stages and proposal files #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

gibson042
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: 8ca38b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

README.md Outdated
| PREPARE | chain software upgrade proposals | submits the proposal, votes on it, runs to halt for the next stage |
| EXECUTE | chain software upgrade proposals | starts `agd` with the new SDK, letting its upgrade handler upgrade the chain |
| EVAL | other proposals | submits the proposal, votes on it, and begin executing. Does not guarantee the eval will finish but does wait several blocks to give it a chance. |
| USE | proposals | Perform actions to update the chain state, to persist through the chain history. E.g. adding a vault that will be tested again in the future. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider "all proposals".

also consider referencing the flow diagram: https://github.com/Agoric/agoric-3-proposals/tree/main/packages/synthetic-chain#design

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the flow diagram to the top-level README.

@gibson042 gibson042 force-pushed the gibson-2025-05-readme-improvements branch 3 times, most recently from 6764e83 to 90780ac Compare May 14, 2025 22:12
AP -- Yes ----> NP
AP -- No ----> END[DEFAULT last use]
```
[dockerfileGen.ts](./src/cli/dockerfileGen.ts) generates a Dockerfile for the multi-stage build described in the [repository README](../../README.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this link will resolve in the NPM content: https://www.npmjs.com/package/@agoric/synthetic-chain

I had put it here so people consuming this package would have docs for it. That's not a priority anymore so I'm fine with you moving it and this breaking. just FYI

@gibson042 gibson042 force-pushed the gibson-2025-05-readme-improvements branch from 90780ac to 8ca38b0 Compare May 14, 2025 22:33
@gibson042 gibson042 merged commit 42310a1 into main May 15, 2025
4 checks passed
@gibson042 gibson042 deleted the gibson-2025-05-readme-improvements branch May 15, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants