Add multi-send #84
Merged
Add multi-send #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as2388
approved these changes
May 13, 2020
rapid_pro_tools/rapid_pro_client.py
Outdated
| log.info(f"Sending a message to {len(urns)} URNs...") | ||
| log.debug(f"Sending to {urns}...") | ||
| batch = [] | ||
| ids = [] |
There was a problem hiding this comment.
Suggested change
| ids = [] | |
| broadcast_ids = [] |
I read this as contact ids at first
rapid_pro_tools/rapid_pro_client.py
Outdated
| interrupted += len(batch) | ||
| log.info(f"Interrupted {interrupted} / {len(urns)} URNs") | ||
|
|
||
| response: Broadcast = self.rapid_pro.create_broadcast(message, urns=batch) |
There was a problem hiding this comment.
I wonder if we should remove the : Broadcast to avoid future confusion, as we're not using type hinting anywhere else
rapid_pro_tools/rapid_pro_client.py
Outdated
Comment on lines
323
to
324
| log.info(f"Interrupted {interrupted} / {len(urns)} URNs") | ||
| log.info(f"Sent {sent} / {len(urns)} URNs") |
There was a problem hiding this comment.
Maybe push these into the if to avoid double printing e.g. 200/200 if the number of requested urns is divisible by 100
Co-authored-by: Alexander Simpson <[email protected]>
Co-authored-by: Alexander Simpson <[email protected]>
Co-authored-by: Alexander Simpson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@as2388 I'd like to add something like this to the code. The testing is going to be pretty laborious - so if you could take a look at the direction to see if you want something different before I start testing that would be great.
I've written it on the basis that we might want to deprecate and remove the 'send to single' API which will make it consistent with the interrupt API we surface.
If you're ok with this, I'll send you a proper PR after I'm done with testing and any changes needed