fixes #2745: Remove cyclic dependency

[royteeuwen]

Remove cyclic dependency by not using OSGi DS to reference the index manager from the EnsureOakIndex OSGi classes

[codecov]

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Project coverage is 56.01%. Comparing base (ef4f406) to head (37816d9).
Report is 83 commits behind head on master.

Files with missing lines	Patch %	Lines
...com/adobe/acs/commons/oak/impl/EnsureOakIndex.java	47.36%	6 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3589      +/-   ##
============================================
+ Coverage     55.54%   56.01%   +0.46%     
- Complexity     5582     5692     +110     
============================================
  Files           728      734       +6     
  Lines         29775    30122     +347     
  Branches       3884     3948      +64     
============================================
+ Hits          16540    16873     +333     
+ Misses        11684    11668      -16     
- Partials       1551     1581      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Test Results

 3 006 files  + 27   3 006 suites  +27   2h 12m 20s ⏱️ - 49m 6s
 1 918 tests +  2   1 918 ✅ +  904  0 💤 ±0  0 ❌  - 151 
17 262 runs  +150  17 256 ✅ +2 852  6 💤 ±0  0 ❌  - 453 

Results for commit 28ccc02. ± Comparison against base commit 530aa75.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

com.adobe.acs.commons.mcp.impl.DynamicScriptServiceProviderTest ‑ Unknown test

com.adobe.acs.commons.oak.impl.EnsureOakIndexTest ‑ testIndexManagerConfigurationAsMultiString
com.adobe.acs.commons.oak.impl.EnsureOakIndexTest ‑ testIndexManagerConfigurationNotSet
com.adobe.acs.commons.oak.impl.EnsureOakIndexTest ‑ testIndexManagerConfigurationSingleString

♻️ This comment has been updated with latest results.

[royteeuwen]

@kwin @davidjgonzalez can you review please :)? Seeing as we no longer build for Java 8, we can upgrade to mockito 5.x, fixing the Java 21 build pipelines that don't allow mockito-inline anymore