Skip to content

Multiple asserts in single test file naming #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025
Merged

Conversation

komkovla
Copy link
Contributor

@komkovla komkovla commented Jul 10, 2025

Summary

  • 🐛 Fix having multiple asserts in single test resulted in name clash and test fail.
  • ✨ Implement counter - singleton for getting count of the snapshot on specific test-device-size combination
  • ❗ Breaking Change - naming of snapshots newly would have _1 suffix so already existing snapshots would need to be renamed

Resolves bug #6

Author checklist

@komkovla komkovla requested a review from olejnjak July 10, 2025 11:23
Copy link
Member

@olejnjak olejnjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that with those two minor tweaks we can maintain backwards compatibility, which would be desirable, what do you think?

@olejnjak olejnjak linked an issue Jul 10, 2025 that may be closed by this pull request
@komkovla
Copy link
Contributor Author

I think that with those two minor tweaks we can maintain backwards compatibility, which would be desirable, what do you think?

Yes, thank you for this improvement!

@olejnjak olejnjak merged commit d57b8a4 into main Jul 10, 2025
1 check passed
@olejnjak olejnjak deleted the bug/multiple-asserts branch July 10, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple asserts in single test produce same file
2 participants