fix: infotext using index 0 #12156
Closed
fix: infotext using index 0 #12156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w-e-w
reviewed
Jul 29, 2023
| @@ -115,7 +115,7 @@ def process_batch(p, input_dir, output_dir, inpaint_mask_dir, args, to_scale=Fal | |||
|
|
|||
| for n, processed_image in enumerate(proc.images): | |||
| filename = image_path.stem | |||
| infotext = proc.infotext(p, n) | |||
| infotext = proc.infotext(p, 0) | |||
There was a problem hiding this comment.
your implementation will cause wrong metadata to be applyed to the image if batch > 1
I made an alternative implementation #12164
|
merged in wew's solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I mentioned issue #12149 , I found that
infotextfunction using index when controlnet included, but seed array only contains just one value. So I modified that infotext funtion uses index 0 during batch processing.Screenshots/videos:
Checklist: