Skip to content

Enable altitude #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2025
Merged

Enable altitude #671

merged 4 commits into from
Jun 16, 2025

Conversation

ma2yama
Copy link
Contributor

@ma2yama ma2yama commented Apr 30, 2025

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️

What kind of change does this PR introduce?

new feature

Can it be referenced to an Issue? If so what is the issue # ?

No

How can we test it?

Set useAltitude to true and run the location-based example.

Summary

Currently, altitude information is not being used. As a result, it's not possible to display content above the current position. By making altitude usage optional, we want to expand what's possible.

Does this PR introduce a breaking change?

No

Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser

Xperia Ace III, Android 14, Chrome 135.0.7049.111

Other information

@kalwalt
Copy link
Member

kalwalt commented May 8, 2025

@ma2yama thank you for this PR, i Will review and test when i have time.

@nickw1
Copy link
Collaborator

nickw1 commented May 12, 2025

Hi @ma2yama @kalwalt I will try and have a look too, I have been a little short of time recently but will hopefully find a bit of time in the next week or two.

@nickw1
Copy link
Collaborator

nickw1 commented Jun 15, 2025

@ma2yama @kalwalt sorry for delay getting back on this. I finally have time this week, I've been very busy at work since around late April - many apologies.

@nickw1
Copy link
Collaborator

nickw1 commented Jun 16, 2025

@ma2yama seems to be working fine. Will merge into dev. Sorry for the delay and many thanks for your contribution!

@nickw1 nickw1 merged commit 0b358aa into AR-js-org:dev Jun 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants