Prepare for running on GKE runners #1681
Merged
+20
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shralex
requested review from
gobbleturk,
khatwanimohit,
bvandermoon,
vipannalla,
RissyRan,
richjames0,
rni418,
gagika,
yangyuwei,
SurbhiJainUSC,
hengtaoguo,
A9isha,
wang2yn84,
wyzhang,
mitalisi,
gpolovets1 and
mailvijayasingh
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
shralex
force-pushed
the
test_cloud_runners1
branch
11 times, most recently
from
9759789 to
66313b0
Compare
shralex
force-pushed
the
test_cloud_runners1
branch
from
66313b0 to
94cbd45
Compare
shralex
force-pushed
the
test_cloud_runners1
branch
from
94cbd45 to
716fb30
Compare
shralex
force-pushed
the
test_cloud_runners1
branch
from
716fb30 to
12ea975
Compare
shralex
force-pushed
the
test_cloud_runners1
branch
from
12ea975 to
2518186
Compare
This PR is testing the use of GKE cloud runners.
shralex
force-pushed
the
test_cloud_runners1
branch
from
2518186 to
af0d7e1
Compare
shralex
changed the title
gobbleturk
approved these changes
May 10, 2025
gobbleturk
reviewed
May 10, 2025
| @@ -67,6 +67,7 @@ jobs: | |||
| with: | |||
| device_type: tpu | |||
| device_name: v4-8 | |||
| # cloud_runner: linux-x86-ct4p-240-4tpu | |||
There was a problem hiding this comment.
what are these comments for? Generally we should not comment out code, its quite confusing
There was a problem hiding this comment.
Is this intentional - is the cloud_runner a cpu runner? why is it under the tpu_unit_tests?
There was a problem hiding this comment.
There are three groups of cloud runners, each one with 1 tag. This one is the tag for TPU runners. You can see them in the runners page. This PR added a new parameter to run_tests_internal (cloud_runner). Basically, once we want to enable this we just need to uncomment these lines. The reason I'm doing this PR now is to allow Rohan to build upon it to enable CPU cloud runners first, because this part should already work.
hengtaoguo
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is refactoring the code to be able to use GKE cloud runners. One of the current requirements of this framework is using containers.
Checklist
Before submitting this PR, please make sure (put X in square brackets):