-
-
Notifications
You must be signed in to change notification settings - Fork 367
Cheap reader for bytes slice #2261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
9672556
initial draft implementation
rmalmain c22af4a
change name to follow rust convention.
rmalmain 75b4563
revert use of HasTargetBytes instead of HasMutatorBytes for BytesSubI…
rmalmain 0557eb1
clippy
rmalmain ce49d42
nostd
rmalmain 20ce359
clippy
rmalmain caa6cac
clippy
rmalmain 0eb55b3
* HasLen required if implementing HasTargetBytes.
rmalmain 050622c
clippy
rmalmain 383a259
Merge branch 'main' into bytes_reader
domenukk 38a7941
fix name.
rmalmain 7657577
Merge branch 'main' into bytes_reader
rmalmain e86ca6a
added a common bytes trait for HasTargetBytes and HasMutatorBytes.
rmalmain 3bfec8f
Merge branch 'main' into bytes_reader
rmalmain 6c28a92
change interface
rmalmain e3e2d8e
fix tests
rmalmain 31aa955
clippers
rmalmain 4763e5c
Merge branch 'main' into bytes_reader
rmalmain 8c76adb
use byte slice for subbytes
rmalmain 7394b54
Merge branch 'main' into bytes_reader
rmalmain 69e34d5
adapt to main
rmalmain 83172d4
fix doc
rmalmain d8e0791
mut sub slice version. return subinput to old state, and add subslice…
rmalmain b6dccc6
Merge branch 'main' into bytes_reader
rmalmain bf1d209
better api, doc fixes.
rmalmain 4197824
Merge branch 'main' into bytes_reader
rmalmain d111e9e
Don't clone, reshuffle
domenukk 1371646
Move and rename
domenukk 2bbf4ef
Uh-oh
domenukk da2d4c6
move to bolts. rename things.
rmalmain d37c630
nostd
rmalmain 8d3c447
format
rmalmain 9092044
alloc
rmalmain fb9b17e
fix doc
rmalmain 04e53a2
Merge branch 'main' into bytes_reader
domenukk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be a blanket impl, keep this one (IMHO)