-
-
Notifications
You must be signed in to change notification settings - Fork 367
Introduce AFL_EXIT_ON_SEED_ISSUES #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
libafl_bolts/src/lib.rs
Outdated
@@ -322,6 +322,8 @@ pub enum Error { | |||
OsError(io::Error, String, ErrorBacktrace), | |||
/// Something else happened | |||
Unknown(String, ErrorBacktrace), | |||
// Error with the corpora | |||
CorpusError(String, ErrorBacktrace), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just name this Corpus
or CorpusInvalid
- Error is redundant.
Ideally we would map the error to one of the other errors but I'm not sure if one of them applies (maybe IllegalState
?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO IllegalState
seems more appropriate for when an invalid action is performed by the user or if external sources modified the items the state depends on (eg. deleting the corpus entry while the fuzzer is running leading to inaccessible corpus entry). Though we could keep it IllegalState
for simplicity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe InvalidCorpus
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, makes more sense.
Whoops, I accidentally force pushed. |
Can you |
… is found during seed loading
Will merge once CI is green :) |
Add documentation to LoadConfig struct fix nostd for LoadConfig
Implements and closes #2067