Fix some missing tracking hints #2058
Conversation
| @@ -179,7 +179,7 @@ pub fn main() { | |||
| if let Some(dynamic_map_size) = executor.coverage_map_size() { | |||
| executor | |||
| .observers_mut() | |||
| .match_name_mut::<HitcountsMapObserver<StdMapObserver<'_, u8, false>>>("shared_mem") | |||
| .match_name_mut::<ExplicitTracking<HitcountsMapObserver<StdMapObserver<'_, u8, false>>, true, false>>("shared_mem") | |||
There was a problem hiding this comment.
Not necessarily beautiful :/ It's because this is a different type now, right? dang...
There was a problem hiding this comment.
Did we make this harder to use instead of easier?
There was a problem hiding this comment.
it's ofcourse more complicated if we add more trait generics to everything when we already had enough of them. previously it was just two additional true false flag to the feedback
There was a problem hiding this comment.
imo i don't think #1886 is worth the complexity if the purpose of it is just to elimitate that too true, false for mapfeedback
There was a problem hiding this comment.
let obs_ref = edges_observer.make_reference();
...
executor
.observers_mut()
.match_name_by_ref("edges", obs_ref)
.as_mut()
.truncate(...);There was a problem hiding this comment.
Note that obs_ref is a ZST and won't affect runtime performance. This all gets elided.
There was a problem hiding this comment.
let obs_ref = edges_observer.make_reference(); ... executor .observers_mut() .match_name_by_ref("edges", obs_ref) .as_mut() .truncate(...);
If this works it's a great solution! :)
There was a problem hiding this comment.
Also, this was a side effect that I mentioned in the original pull request (i.e., wrapping types). I don't understand why this is now an issue if it was okay when I submitted the pull request.
In our defense, this part was missing in the pull request :P
This reverts commit edcff38.
Addresses some concerns following #1886.