Fix build with Qt 5.11 #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've slightly changed your commit, so please check whether STA is built with Qt 5.11 now. For that, clone STA from develop branch. |
|
I see you moved the headers into cpp files, that will require more changes: |
|
It should be ok now. |
|
Confirmed, your 'develop' branch built fine now against Qt-5.11_beta3. |
|
a17r, wonderful, good work, ty. |
|
Merge? 🤔 |
This was referenced May 31, 2018
christofchen
pushed a commit
to christofchen/scantailor-advanced
that referenced
this pull request
Jul 16, 2023
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Qt 5.11 causes failing packages everywhere because of internal header cleanup, this commit is fixing scantailor-advanced.