Feature/image loading callback improvements #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… view so the closure sent to the method is always called even if multiple requests are made in quick succession. This guarantees callers of this method will always get the completion handler called, even if it was simply cancelled
even on cancelled request
Doesn't reload row unless image is actually fetched Doesn't try to load image unless `imageURL` is provided
BenShutt
reviewed
Aug 14, 2020
| indexPathsToReload.append(indexPath) | ||
| } | ||
| guard !indexPathsToReload.isEmpty else { return } | ||
| self.tableView.reloadRows(at: indexPathsToReload, with: .none) |
There was a problem hiding this comment.
@simonmitchell Did you mean to pass animation here?
BenShutt
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes sure image load completion is called even due to cancellation of requests
Motivation and Context
Had an issue in apps where the completion for loading an image was never called in some cases. This resolves the issue.
How Has This Been Tested?
Has been tested in my personal app Camrote.
Screenshots (if appropriate):
Types of changes
Checklist: