Skip to content

Add printk when in data abort #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add printk when in data abort #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/arch/armv8/aborts.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ void aborts_data_lower(uint64_t iss, uint64_t far, uint64_t il)

vaddr_t addr = far;
emul_handler_t handler = vm_emul_get_mem(cpu.vcpu->vm, addr);
if (addr <= 0xff000000) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this value exactly?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose I have found the reason here crosscon/CROSSCON-Hypervisor-and-TEE-Isolation-Demos#32 (comment):

You should add some prints there, possibly with an if condition to only print on addresses you know are memory to prevent gic accesses from cluttering the output.

Trying to map this if on the configuration you are using.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I understood wrong but gic starts at around 0xff*:

CROSSCON-Hypervisor/src/platform/rpi4/rpi4_desc.c

Line 35 in c8711ea

.gicd_addr = 0xff841000,

and I thought that meant I should print only when address doesn't belong to range used by gic?

printk("CROSSCONHYP DATA ABORT: 0x%x\n", addr);
}
if (handler != NULL) {
struct emul_access emul;
emul.addr = addr;
Expand Down