-
Notifications
You must be signed in to change notification settings - Fork 72
fix: refactor oauth2 support for earthscope-sdk #6194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: refactor oauth2 support for earthscope-sdk #6194
Conversation
Merging this PR will trigger the following deployment actions. Support deploymentsNo support upgrades will be triggered Staging deployments
Production deployments
|
@hamilton-earthscope ty for the PR! I've rebased and deployed this to staging.geolab.earthscope.cloud/hub/oauth_login. I think it's failing because the JSON needs to be escaped. Here's the exception:
So this is a python string.format that needs to be escaped - primarily |
@hamilton-earthscope that seems to have fixed it. I deployed it in https://staging.geolab.earthscope.cloud/hub/oauth_login. wanna test and verify, and i'll deploy to prod? |
@yuvipanda it looks good on my end, thank you. Can we hold off on merging this/deploying to prod until we are able to update our default image with a new version of our SDK? |
@hamilton-earthscope great! Let me know and I'll merge. |
This PR reconfigures how EarthScope's oauth2 context is injected into spawned containers